Re: [Patch 1/8] kexec: allow to shrink reserved memory

[Amerigo Wang]

Andrew Morton wrote:
> On Fri, 21 Aug 2009 02:54:25 -0400
> Amerigo Wang <amwang@xxxxxxxxxx> wrote:
>
>   
> > +size_t get_crash_memory_size(void)
> > +int shrink_crash_memory(unsigned long new_size)
> >     
>
> These aren't particualrly well-chosen global identifiers.  It would be
> better if they were called crash_*() or kexec_*(), to make it clear
> which subsystem they belong to.
>
>   

Ah, good poi nt!

How about crash_get_memory_size() and crash_shrink_memory()?

Thanks!



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/