Re: [PATCH v2 2/2] tracing: Create generic syscall TRACE_EVENTs

From: Josh Stone
Date: Fri Aug 21 2009 - 15:37:37 EST


On 08/21/2009 10:57 AM, Jason Baron wrote:
>> +TRACE_EVENT_WITH_CALLBACK(sys_enter,
>
> don't we want to change this to something like 'sys_enter_generic'?
> otherwise, looks good.

Since all of the specific events are named "sys_enter_foo", I thought
that it would be clear that an unadorned "sys_enter" was the more
generic syscall event. Calling it "sys_enter_generic" seems to me by
convention to mean a system call named "generic".

I don't want to bikeshed this though -- if you still think
"sys_enter_generic" is better, then I'll change it.

Thanks,

Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/