Re: [PATCH] x86: add /proc/cpuinfo/physical id quirks

[H. Peter Anvin]

On 08/20/2009 02:26 PM, Suresh Siddha wrote:
> On Thu, 2009-08-20 at 14:20 -0700, Alex Chiang wrote:
>> It turns out I need to rework my patch anyway because I need to
>> think about the case where a user disables some cores in the
>> BIOS, in which case my (fragile) table selection scheme falls
>> apart.
> 
> These are the sort of reasons why we want topology detection to be
> completely based on what cpuid instruction says and nothing else.
> 

I agree... if this ID is used for topology detection, we shouldn't
replace it arbitrarily with information from BIOS just to hope that it
matches the motherboard stencil.  *Furthermore*, there is no reason why
motherboard stencilAs are purely numeric... consider the rather obvious
case of two rows of four CPUs; they may have CPU slots labelled A1, A2,
A3, A4, B1, B2, B3, B4.  It might very well be the right thing to
support arbitrary strings for platforms we recognize.

As such I think we should have a socket name field in both /proc/cpuinfo
and sysfs.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/