Re: [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup

From: Paul Menage
Date: Thu Aug 20 2009 - 17:16:32 EST


On Thu, Aug 20, 2009 at 2:13 PM, Andrew Morton<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>> >
>> > s/tsk->sighand/p->sighand
>>
>> Good catch, thanks. Fixed.
>>
>
> I see no fix anywhere so I did this:

I meant fixed in my tree to go out in the next set of patches.


>
> --- a/kernel/cgroup.c~cgroups-add-functionality-to-read-write-lock-clone_thread-forking-per-threadgroup-fix
> +++ a/kernel/cgroup.c
> @@ -1557,7 +1557,7 @@ struct sighand_struct *threadgroup_fork_
>                rcu_read_lock();
>                list_for_each_entry_rcu(p, &tsk->thread_group, thread_group) {
>                        if (p->sighand) {
> -                               sighand = tsk->sighand;
> +                               sighand = p->sighand;
>                                break;
>                        }
>                }

Yes, looks good.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/