Re: linux-next: suspend tree build warnings

From: Rafael J. Wysocki
Date: Wed Aug 19 2009 - 17:37:29 EST


On Wednesday 19 August 2009, Stephen Rothwell wrote:
> Hi Rafael,

Hi,

> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
>
> drivers/media/dvb/frontends/dib7000p.c: In function âdib7000p_i2c_enumerationâ:
> drivers/media/dvb/frontends/dib7000p.c:1315: warning: the frame size of 2256 bytes is larger than 2048 bytes
> drivers/media/dvb/frontends/dib3000mc.c: In function âdib3000mc_i2c_enumerationâ:
> drivers/media/dvb/frontends/dib3000mc.c:853: warning: the frame size of 2160 bytes is larger than 2048 bytes
>
> Introduced by commit 99307958cc9c1b0b2e0dad4bbefdafaf9ac5a681 ("PM:
> Introduce core framework for run-time PM of I/O devices (rev. 17)").

Well.

This commit increases the size of struct device quite a bit and both of the
drivers above create a "state" object on the stack that contains struct device
among other things.

I think they should allocate these objects using kmalloc() and I don't know
what I can do about this, really. Maybe except for modifying the drivers to
use kmalloc().

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/