Re: [PATCH 2/3] Add rfkill support to compal-laptop

From: Johannes Berg
Date: Wed Aug 19 2009 - 14:43:35 EST


On Wed, 2009-08-19 at 13:36 -0500, Mario Limonciello wrote:
> Signed-off-by: Mario Limonciello <Mario_Limonciello@xxxxxxxx>
> Reviewed-by: Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>

> + ret = setup_rfkill();
> + if (ret)
> + goto fail_rfkill;
> +
> printk(KERN_INFO "compal-laptop: driver "COMPAL_DRIVER_VERSION
> " successfully loaded.\n");
>
> return 0;
>
> +fail_rfkill:
> fail_platform_device2:

Isn't that missing sysfs_remove_group()?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part