Re: [PATCH] MFD AB3100 OTP readout v2

From: Linus Walleij
Date: Wed Aug 19 2009 - 03:01:03 EST


2009/8/19 Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>:

> I still dont get why you want that to be a device by its own.

Mainly two things:

- The AB3100 HW is partitioned into different logical blocks, one deals with
battery charging, one with LEDs etc, and one partition is OTP. Doing
a platform device for each gives a 1-1 match between spec and HW.

> Having a no-op for ab3100_otp_probe() when AB3100_OTP is not defined would be
> a lighter solution, wouldn't it ?

Yep at the cost of an extra .h file for the interface.

No problem though, I'll cook up a v3 the way you want it, it's no
big issue...

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/