Re: [RFC] respect the referenced bit of KVM guest pages?

[Minchan Kim]

Hi, Wu.

On Sun, Aug 16, 2009 at 8:29 PM, Wu Fengguang<fengguang.wu@xxxxxxxxx> wrote:
> On Sun, Aug 16, 2009 at 01:15:02PM +0800, Wu Fengguang wrote:
>> On Sun, Aug 16, 2009 at 11:53:00AM +0800, Rik van Riel wrote:
>> > Wu Fengguang wrote:
>> > > On Fri, Aug 07, 2009 at 05:09:55AM +0800, Jeff Dike wrote:
>> > >> Side question -
>> > >> ÂIs there a good reason for this to be in shrink_active_list()
>> > >> as opposed to __isolate_lru_page?
>> > >>
>> > >> Â Â Â Â Âif (unlikely(!page_evictable(page, NULL))) {
>> > >> Â Â Â Â Â Â Â Â Âputback_lru_page(page);
>> > >> Â Â Â Â Â Â Â Â Âcontinue;
>> > >> Â Â Â Â Â}
>> > >>
>> > >> Maybe we want to minimize the amount of code under the lru lock or
>> > >> avoid duplicate logic in the isolate_page functions.
>> > >
>> > > I guess the quick test means to avoid the expensive page_referenced()
>> > > call that follows it. But that should be mostly one shot cost - the
>> > > unevictable pages are unlikely to cycle in active/inactive list again
>> > > and again.
>> >
>> > Please read what putback_lru_page does.
>> >
>> > It moves the page onto the unevictable list, so that
>> > it will not end up in this scan again.
>>
>> Yes it does. I said 'mostly' because there is a small hole that an
>> unevictable page may be scanned but still not moved to unevictable
>> list: when a page is mapped in two places, the first pte has the
>> referenced bit set, the _second_ VMA has VM_LOCKED bit set, then
>> page_referenced() will return 1 and shrink_page_list() will move it
>> into active list instead of unevictable list. Shall we fix this rare
>> case?

I think it's not a big deal.

As you mentioned, it's rare case so there would be few pages in active
list instead of unevictable list.
When next time to scan comes, we can try to move the pages into
unevictable list, again.

As I know about mlock pages, we already had some races condition.
They will be rescued like above.

>
> How about this fix?
>
> ---
> mm: stop circulating of referenced mlocked pages
>
> Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> ---
>
> --- linux.orig/mm/rmap.c    Â2009-08-16 19:11:13.000000000 +0800
> +++ linux/mm/rmap.c   2009-08-16 19:22:46.000000000 +0800
> @@ -358,6 +358,7 @@ static int page_referenced_one(struct pa
> Â Â Â Â */
> Â Â Â Âif (vma->vm_flags & VM_LOCKED) {
> Â Â Â Â Â Â Â Â*mapcount = 1; Â/* break early from loop */
> + Â Â Â Â Â Â Â *vm_flags |= VM_LOCKED;
> Â Â Â Â Â Â Â Âgoto out_unmap;
> Â Â Â Â}
>
> @@ -482,6 +483,8 @@ static int page_referenced_file(struct p
> Â Â Â Â}
>
> Â Â Â Âspin_unlock(&mapping->i_mmap_lock);
> + Â Â Â if (*vm_flags & VM_LOCKED)
> + Â Â Â Â Â Â Â referenced = 0;
> Â Â Â Âreturn referenced;
> Â}
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx ÂFor more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
>



-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/