Re: [PATCH v2] Add watchdog driver for w90p910

From: Wan ZongShun
Date: Sun Aug 16 2009 - 22:40:55 EST


Dear Wim,

Thanks for your w90p910-v2.diff, I appreciated it.
I have tested it and only modified the quote of 'expect_close',
and now the patch works very well.:)

At the same time, I renamed this driver name, due to I
have changed the corresponding device name in my arch file.

The attached file is fixed patch relative to this w90p910-v2.diff.

Signed-off-by: Wan ZongShun <mcuos.com@xxxxxxxxx>

---
drivers/watchdog/w90p910_wdt.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/w90p910_wdt.c b/drivers/watchdog/w90p910_wdt.c
index 3cb8972..741db53 100644
--- a/drivers/watchdog/w90p910_wdt.c
+++ b/drivers/watchdog/w90p910_wdt.c
@@ -137,7 +137,7 @@ static int w90p910_wdt_open(struct inode *inode, struct file *file)

static int w90p910_wdt_close(struct inode *inode, struct file *file)
{
- if (expect_close == 42)
+ if (w90p910_wdt->expect_close == 42)
w90p910_wdt_stop();
else {
dev_crit(&w90p910_wdt->pdev->dev,
@@ -328,7 +328,7 @@ static struct platform_driver w90p910wdt_driver = {
.probe = w90p910wdt_probe,
.remove = __devexit_p(w90p910wdt_remove),
.driver = {
- .name = "w90p910-wdt",
+ .name = "nuc900-wdt",
.owner = THIS_MODULE,
},
};
@@ -350,4 +350,4 @@ MODULE_AUTHOR("Wan ZongShun <mcuos.com@xxxxxxxxx>");
MODULE_DESCRIPTION("Watchdog driver for W90P910");
MODULE_LICENSE("GPL");
MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
-MODULE_ALIAS("platform:w90p910-wdt");
+MODULE_ALIAS("platform:nuc900-wdt");
--
1.5.6.3


Fix watchdog driver for w90p910 platform.

Signed-off-by: Wan ZongShun <mcuos.com@xxxxxxxxx>

---
drivers/watchdog/w90p910_wdt.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/w90p910_wdt.c b/drivers/watchdog/w90p910_wdt.c
index 3cb8972..741db53 100644
--- a/drivers/watchdog/w90p910_wdt.c
+++ b/drivers/watchdog/w90p910_wdt.c
@@ -137,7 +137,7 @@ static int w90p910_wdt_open(struct inode *inode, struct file *file)

static int w90p910_wdt_close(struct inode *inode, struct file *file)
{
- if (expect_close == 42)
+ if (w90p910_wdt->expect_close == 42)
w90p910_wdt_stop();
else {
dev_crit(&w90p910_wdt->pdev->dev,
@@ -328,7 +328,7 @@ static struct platform_driver w90p910wdt_driver = {
.probe = w90p910wdt_probe,
.remove = __devexit_p(w90p910wdt_remove),
.driver = {
- .name = "w90p910-wdt",
+ .name = "nuc900-wdt",
.owner = THIS_MODULE,
},
};
@@ -350,4 +350,4 @@ MODULE_AUTHOR("Wan ZongShun <mcuos.com@xxxxxxxxx>");
MODULE_DESCRIPTION("Watchdog driver for W90P910");
MODULE_LICENSE("GPL");
MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
-MODULE_ALIAS("platform:w90p910-wdt");
+MODULE_ALIAS("platform:nuc900-wdt");
--
1.5.6.3