RE: [PATCH 1/1] intel_txt: to fix build errors of CONFIG_ACPI_SLEEP

From: Wang, Shane
Date: Fri Aug 14 2009 - 04:53:58 EST


H. Peter Anvin wrote:
> On 08/13/2009 07:06 PM, Wang, Shane wrote:
>> I agree with hpa, considering TXT doesnot depends on acpi sleep.
>>
>> takes effect but tboot->mac_regions[] will never be used without S3.
>>
>
> Given that, I would create a function called tboot_setup_suspend() or
> something like that and localize the setting of mac_regions as well as
> s3_resume_vector there.
>
> Since it looks like s3_resume_vector is simply set up in tboot_sleep()
> before we'd call tboot_shutdown(), we can presumably simply do it all
> in tboot_shutdown().
>
> Ingo, Shane: how does the attached patch look?
>
> -hpa

ACK.

Thanks.
Shane--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/