Re: [RFC patch] init default dma_ops to prepare intel_iommu_init failure

[FUJITA Tomonori]

On Thu, 13 Aug 2009 15:37:54 +0800
Luming Yu <luming.yu@xxxxxxxxx> wrote:

> On Thu, Aug 13, 2009 at 3:14 PM, FUJITA
> Tomonori<fujita.tomonori@xxxxxxxxxxxxx> wrote:
> > On Thu, 13 Aug 2009 15:03:20 +0800
> > Luming Yu <luming.yu@xxxxxxxxx> wrote:
> >
> >> Thanks for another workaround, we should be working on deleting wrong
> >> assumption of"iommu_deteced == iommu working", Not just workaround. My
> >> patch could break something.. but it is just a start towards right
> >> goal..
> >
> > As I explained, your patch doesn't go toward the right goal.
> 
> The goal is to decouple dma_ops init and iommu_detect.
> In that sense, my patch is right.

No, your patch is a workaround too.

If you want swiotlb the default dma_ops for IA64, pci_swiotlb_init()
is the wrong place for swiotlb_init() because sba needs swiotlb too
for the same reason. Probably, we should always set platform_dma_init
to swiotlb_dma_init().


You want to fix this problem for 2.6.31? Or you think about 2.6.32 (or
later)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/