Re: [RFC v6][PATCH 0b/4] intel_txt: Intel(R) Trusted Execution Technologysupport for Linux - Details

[H. Peter Anvin]

On 08/12/2009 09:30 AM, Arjan van de Ven wrote:
> H. Peter Anvin wrote:
>> On 08/12/2009 08:42 AM, Wang, Shane wrote:
>>> oh, S3 support by TXT is one of TXT support. We have code to secure
>>> S3 sleep and resume.
>>> Without S3 support, TXT code is incomplete.
>>>
>>
>> That doesn't make any sense.
>>
>> The question is: if the user doesn't want S3, do they still need to
>> enable S3 in order to be able to use TXT?  Otherwise, this code needs to
>> be properly conditionalized.
>>
> 
> it's the other way around
> if you have S3 support, you also need the TXT S3 piece.
> the S3 piece of TXT is irrelevant if you cannot do S3.

Right.  Which means the S3 TXT part should be conditionalized on
CONFIG_ACPI_SLEEP.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/