Re: [ofa-general] Re: [PATCH 10/14] infiniband: use printk_once

From: Roland Dreier
Date: Mon Aug 10 2009 - 13:42:33 EST



> I'm a bit nervous about this one.
> printk_once will print once ONLY if CONFIG_PRINTK is set in include/linux/autoconf.h
> (i.e., when the kernel is configured). Otherwise, it gets defined to printk --
> and it will always print in this case.
> (see 2.6.30.xx kernel include file "include/linux/kernel.h", lines 235, 249, and 272).

Umm... if CONFIG_PRINTK is turned off nothing prints, right?

> Do you think that distributions will ALWAYS have CONFIG_PRINTK defined?

Yes, I suspect they do want to get kernel messages.

- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/