Re: xterm loses data (pty regression)

[Alan Cox]

On Mon, 10 Aug 2009 10:18:41 -0700 (PDT)
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> 
> 
> On Mon, 10 Aug 2009, Ray Lee wrote:
> > On Mon, Aug 10, 2009 at 8:29 AM, Artur Skawina <art.08.09@xxxxxxxxx> wrote:
> > >
> > > First noticed it after upgrading to v2.6.31-rc5-246-g90bc1a6, still happens
> > > in rc5-381-g7b2aa03.
> > > If i press ^S in an xterm the output stops as expected, but after a ^Q i see
> > > only the newly written data, everything in between is lost. 
> 
> Yup, I can confirm that. 
> 
> > > > for i in `seq 1 111`; do echo $i; sleep 1; done
> 
> (Do ^S/^Q, see data loss)
> 
> Will take a look asap, thanks. Although I bet it's the same old commit 
> (d945cb9cc: "pty: Rework the pty layer to use the normal buffering logic") 
> again.

My guess too. The old pty code abuses throttle/unthrottle in odd ways.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/