Re: [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.h in davinci_wdt.c

From: Kevin Hilman
Date: Mon Aug 10 2009 - 12:48:19 EST


Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> writes:

> On Sun, Aug 09, 2009 at 11:36:39AM +0200, Uwe Kleine-König wrote:
>> This fixes a a build failure for 2.6.31-rc4-rt1 (ARCH=arm,
>> davinci_all_defconfig):
>>
>> drivers/watchdog/davinci_wdt.c: In function 'wdt_enable':
>> drivers/watchdog/davinci_wdt.c:102: error: 'CLOCK_TICK_RATE' undeclared (first use in this function)
>> drivers/watchdog/davinci_wdt.c:102: error: (Each undeclared identifier is reported only once
>> drivers/watchdog/davinci_wdt.c:102: error: for each function it appears in.)
>
> It should not be using CLOCK_TICK_RATE - there was a move to clean
> up the use of that symbol and restrict it just to the i8253 PIT.
> Please create something else like DAVINCI_TICK_RATE instead.

Actually, I have an alternate fix for this which I was planning to
submit for 2.6.32. This one drops CLOCK_TICK_RATE and uses the clock
framework to get the right tick frequency.

Here it is.

Kevin