Re: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based/dev

[Pavel Machek]

Hi!

> --- /dev/null
> +++ b/drivers/base/devtmpfs.c
> @@ -0,0 +1,367 @@
> +/*
> + * devtmpfs - kernel-maintained tmpfs-based /dev
> + *
> + * Copyright (C) 2009, Kay Sievers <kay.sievers@xxxxxxxx>
> + *

I'd expect GPL notice here...

> +#if defined CONFIG_DEVTMPFS_MOUNT
> +static int dev_mount = 1;
> +#else
> +static int dev_mount;
> +#endif


A bit too many config options?

> +#ifdef CONFIG_BLOCK
> +static inline int is_blockdev(struct device *dev)
> +{
> +	return dev->class == &block_class;
> +}
> +#else
> +static inline int is_blockdev(struct device *dev) { return 0; }

Should this go to header somewhere?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/