Re: [Linux-fbdev-devel] [PATCH 3/3] drivers/video: Correct use of request_region/request_mem_region

[Geert Uytterhoeven]

On Sun, Aug 9, 2009 at 09:44, Julia Lawall<julia@xxxxxxx> wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> request_region should be used with release_region, not request_mem_region.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r1@
> expression start;
> @@
>
> request_region(start,...)
>
> @b1@
> expression r1.start;
> @@
>
> request_mem_region(start,...)
>
> @depends on !b1@
> expression r1.start;
> expression E;
> @@
>
> - release_mem_region
> + release_region
> Â(start,E)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@xxxxxxx>
>
> ---
> Âdrivers/video/gbefb.c Â| Â Â4 ++--
> Âdrivers/video/tdfxfb.c | Â Â4 ++--
> Â2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff -u -p a/drivers/video/gbefb.c b/drivers/video/gbefb.c
> --- a/drivers/video/gbefb.c
> +++ b/drivers/video/gbefb.c
> @@ -1246,7 +1246,7 @@ out_tiles_free:
> Âout_unmap:
> Â Â Â Âiounmap(gbe);
> Âout_release_mem_region:
> - Â Â Â release_mem_region(GBE_BASE, sizeof(struct sgi_gbe));
> + Â Â Â release_region(GBE_BASE, sizeof(struct sgi_gbe));

GBE_BASE seems to be MMIO (it's mapped using ioremap()), so it looks like the
release_mem_region() is actually correct, while the request_region() should be
request_mem_region() instead

> Âout_release_framebuffer:
> Â Â Â Âframebuffer_release(info);
>
> @@ -1265,7 +1265,7 @@ static int __devexit gbefb_remove(struct
> Â Â Â Â Â Â Â Âiounmap(gbe_mem);
> Â Â Â Âdma_free_coherent(NULL, GBE_TLB_SIZE * sizeof(uint16_t),
> Â Â Â Â Â Â Â Â Â Â Â Â Â(void *)gbe_tiles.cpu, gbe_tiles.dma);
> - Â Â Â release_mem_region(GBE_BASE, sizeof(struct sgi_gbe));
> + Â Â Â release_region(GBE_BASE, sizeof(struct sgi_gbe));

Ditto.

> diff -u -p a/drivers/video/tdfxfb.c b/drivers/video/tdfxfb.c
> --- a/drivers/video/tdfxfb.c
> +++ b/drivers/video/tdfxfb.c
> @@ -1571,8 +1571,8 @@ out_err_iobase:
> Â Â Â Âif (default_par->mtrr_handle >= 0)
> Â Â Â Â Â Â Â Âmtrr_del(default_par->mtrr_handle, info->fix.smem_start,
> Â Â Â Â Â Â Â Â Â Â Â Â info->fix.smem_len);
> - Â Â Â release_mem_region(pci_resource_start(pdev, 2),
> - Â Â Â Â Â Â Â Â Â Â Â Â Âpci_resource_len(pdev, 2));
> + Â Â Â release_region(pci_resource_start(pdev, 2),
> + Â Â Â Â Â Â Â Â Â Â Âpci_resource_len(pdev, 2));
> Âout_err_screenbase:
> Â Â Â Âif (info->screen_base)
> Â Â Â Â Â Â Â Âiounmap(info->screen_base);

This one looks OK.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/