Re: [PATCH] perf_counter: Fix a race on perf_counter_ctx

From: Ingo Molnar
Date: Sat Aug 08 2009 - 08:04:40 EST



* Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> On Fri, 2009-08-07 at 13:33 +0200, Ingo Molnar wrote:
> > Peter, any ideas?
>
>
> > [ 995.556131] ------------[ cut here ]------------
> > [ 995.557128] WARNING: at kernel/perf_counter.c:1191 __perf_counter_task_sched_out+0x48/0x6b()
>
>
> Some yeah...

This patch fixed both the warning i was getting during stress-tests,
and it also solved the hard lockup i was getting with the latest BTS
patch.

( perf record never actually finishes even short workloads, due to
the flood of kernel events coming in faster than it can record, so
we grow and grow the perf.data - but that's a different matter, it
does not lock up anymore. )

Markus, does latest -tip work fine for you, is the lockup fixed on
your side as well?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/