Re: [PATCH] markup_oops: Use modinfo to avoid confusion with underscoredmodule names

From: Ozan ÃaÄlayan
Date: Thu Aug 06 2009 - 11:32:27 EST


Arjan van de Ven wrote:
> On Thu, 6 Aug 2009 15:21:55 +0300
> Ozan ÃaÄlayan <ozan@xxxxxxxxxxxxx> wrote:
>
>
>> When EIP is at a module having an underscore in its name, the current
>> code fails to find it because the module filenames has '-' instead of
>> '_'.
>>
>> Use modinfo to correctly get the full path to the module.
>>
>> Signed-off-by: Ozan ÃaÄlayan <ozan@xxxxxxxxxxxxx>
>>
>
> I like it, it's simple.
> I don't mind about the module-init-tools dependency, everyone will have
> that already.
>

BTW, note that the old code was searching for *.ko files in
dirname($vmlinux_name). Replacing it by modprobe will eventually always
search for the modules in /lib/modules/KVER/.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/