Re: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev

From: Kay Sievers
Date: Wed Aug 05 2009 - 20:19:47 EST


On Thu, Aug 6, 2009 at 02:06, Greg KH<greg@xxxxxxxxx> wrote:
> On Wed, Aug 05, 2009 at 09:55:49PM +0100, Alan Jenkins wrote:

>> > + Â Â Â Â Â Â Â Â Â err = vfs_mkdir(nd.path.dentry->d_inode,
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â dentry, 0775);
>>
>> Is there a typo here? ÂI think the mode should be 0755. Â 0755 is used
>> below, and that does fit better with the 0600 mode for device nodes.
>
> Yeah, I think you are correct. ÂKay, any objection to me making this
> change?

No, sure no objection. It sounds right to use 0755.
I was just waiting if more things to fix come up. :)

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/