Re: [PATCH 1/6] lib/decompress_*: only include <linux/slab.h> ifSTATIC is not defined

From: Andrew Morton
Date: Tue Aug 04 2009 - 18:56:11 EST


On Mon, 3 Aug 2009 16:58:16 +0200
Albin Tonnerre <albin.tonnerre@xxxxxxxxxxxxxxxxxx> wrote:

> These includes were added by 079effb6933f34b9b1b67b08bd4fd7fb672d16ef to
> fix the build when using kmemtrace. However this is not necessary when
> used to create a compressed kernel, and actually creates issues (brings
> a lot of things unavailable in the decompression environment), so don't
> include it if STATIC is defined.
>

The description "actually creates issues (brings a lot of things
unavailable in the decompression environment)" is inadequate. Please
describe te problem this patch fixes more completely so that others
(ie: me) can decide whether this patch is needed in 2.6.32, 2.6.31.
2.6.30, ...


This patch conflicts heavily with

http://userweb.kernel.org/~akpm/mmotm/broken-out/bzip2-lzma-remove-nasty-uncompressed-size-hack-in-pre-boot-environment.patch


What should we do about that?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/