Re: [patch -mm v2] mm: introduce oom_adj_child

From: David Rientjes
Date: Mon Aug 03 2009 - 04:09:08 EST


On Mon, 3 Aug 2009, KAMEZAWA Hiroyuki wrote:

> > You can't recalculate it if all the remaining threads have a different
> > oom_adj value than the effective oom_adj value from the thread that is now
> > exited.
>
> Then, crazy google apps pass different oom_adjs to each thread ?
> And, threads other than thread-group-leader modifies its oom_adj.
>

Nope, but I'm afraid you've just made my point for me: it shows that
oom_adj really isn't sanely used as a per-thread attribute and actually
only represents a preference on oom killing a quantity of memory in all
other cases other than vfork() -> change /proc/pid-of-child/oom_adj ->
exec() for which we now appropriately have /proc/pid/oom_adj_child for.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/