Re: [tip:core/debug] debug lockups: Improve lockup detection

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

>  #ifndef trigger_all_cpu_backtrace
> +#ifdef CONFIG_SMP
> +#warning This architecture is missing a trigger_all_cpu_backtrace() implementation
> +#endif
>  #define trigger_all_cpu_backtrace() do { } while (0)
>  #endif

I think a better solution will be to make this function return 1 if 
it generated a backtrace.

That way we can fall back to the generic schedule_work based 
codepath.

Albeit the best and cleanest solution would be to implement a 
workqueue based trigger_all_cpu_backtrace() __weak variant and throw 
away the workqueue bits from sysrq.c.

	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/