Re: [PATCH] clocksource: save mult_orig in clocksource_disable()

[john stultz]

On Fri, 2009-07-31 at 23:23 +0900, Magnus Damm wrote:
> On Fri, Jul 31, 2009 at 9:18 PM, Ingo Molnar<mingo@xxxxxxx> wrote:
> >
> > * Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
> >
> >> On Fri, Jun 19, 2009 at 4:17 AM, john stultz<johnstul@xxxxxxxxxx> wrote:
> >> > On Fri, 2009-06-19 at 00:24 +0900, Magnus Damm wrote:
> >> >> From: Magnus Damm <damm@xxxxxxxxxx>
> >> >>
> >> >> Save clocksource mult_orig in clocksource_disable().
> >> >>
> >> >> To fix the common case where ->enable() does not setup
> >> >> mult, make sure mult_orig is saved in mult on disable.
> >> >>
> >> >> Also add comments to explain why we do this.
> >> >>
> >> >> Signed-off-by: Magnus Damm <damm@xxxxxxxxxx>
> >> >
> >> > Acked-by: John Stultz <johnstul@xxxxxxxxxx>
> >> >
> >> > Thomas, Andrew, please push this for 2.6.31.
> >>
> >> This one is slowly making it's way in I suppose?
> >
> > Btw., what specific issue does this fix? The commit description is
> > generic, there's no bugzilla link and no other information either
> > that could give me an idea about precisely what incarnation of the
> > bug you have hit.
> 
> The comments in the actual code gives more details, but that's
> probably not where you want this to be explained. I can resend a
> version with more verbose commit message early next week if you'd
> like. Please let me know if so.
> 
> I'm not aware of any bugzilla links, maybe John knows?

No bugzilla link. I found this while reviewing the patch, however at
that point it had already been pulled into -tip and my objections
somehow never made it to anyone's eyes before it got pulled into
mainline.

thanks
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/