Re: [PATCH] [mtd] fixed faulty check

From: Sebastian Andrzej Siewior
Date: Thu Jul 30 2009 - 09:48:18 EST


vimal singh wrote:
What if you go to 'err_out' due to some other error?? Do not you need
to free 'info'?
We have to and of_flash_remove() takes care of it.

The initial patch would be shorter if
dev_set_drvdata(&dev->dev, info);
would be moved prior the kzalloc()

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/