Re: [PATCH] kmemleak: Protect the seq start/next/stop sequence byrcu_read_lock()

From: Andrew Morton
Date: Wed Jul 29 2009 - 20:00:54 EST


On Wed, 29 Jul 2009 16:26:57 +0100
Catalin Marinas <catalin.marinas@xxxxxxx> wrote:

> Objects passed to kmemleak_seq_next() have an incremented reference
> count (hence not freed) but they may point via object_list.next to
> other freed objects. To avoid this, the whole start/next/stop sequence
> must be protected by rcu_read_lock().
>
> Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> ---
>
> This is a fix for bug #13761 in buzilla.kernel.org. If there are no
> objections, please apply it before 2.6.31. Thanks.

Administrivia:

When referencing a bugzilla report, please quote the full URL within
the changelog (not after the ^---$). I use:

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13761

This is because people ocassionally troll the commit logs, closing off
bugzilla reports. Using a standardised format simplifies that job, and
makes it more reliable.

Also, it's nice to give the original bug reporter a Reported-by: in the
changelog. As a little thank-you, and so they know what's going on.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/