RE: [PATCH] dmaengine: at_hdmac: add DMA slave transfers

[Sosnowski, Maciej]

Atsushi Nemoto wrote:
> On Mon, 27 Jul 2009 14:24:26 +0100, "Sosnowski, Maciej" <maciej.sosnowski@xxxxxxxxx> wrote:
>>>> Your atc_chain_complete() calls dma_unmap_xxx unless
>>>> DMA_COMPL_SKIP_XXX_UNMAP specified.  But atmel-mci driver does not set
>>>> the flag on dma_async_tx_descriptor.  I suppose one of them should be
>>>> fixed.
>>> 
>>> atmel-mci should definitely set that flag.
>>> 
>>> Haavard
>> 
>> I agree with Haavard.
> 
> Then, what should dma driver do when client driver did not set these
> flags?  If it should call dma_unmap_sg(), the dma driver should keep
> sg and direction somewhere...

Well, what about BUG_ON?

> 
> Also, calling dma_map_sg() in its prep_slave_sg function will not fit
> for sound drivers, which use DMA buffers prepared in its framework.

It looks like a need for one more flag: DMA_SKIP_MAP_SG.
What do you think?

Regards,
Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/