Re: [PATCH v2 -tip][RFC] serial8250: update to dev_pm_ops

[Rafael J. Wysocki]

On Sunday 26 July 2009, Frans Pop wrote:
> On Sunday 26 July 2009, Rafael J. Wysocki wrote:
> > In fact, I wouldn't advise anyone to do these conversions mechanically.
> 
> With hindsight I'd say you are correct.
> 
> In that case would it maybe have been better to have a build time warning 
> about the need to convert drivers rather than a run time one? Run time 
> warnings have a much higher annoyance factor and will thus "invite" more 
> people into having a shot at getting rid of them.
> 
> But I guess partly it's also just the nature of this change: it looks 
> trivial due to the corresponding terms.

Well, in fact the patch that added the warning wasn't mine. :-)

Anyway, the purpose was to get the attention of the people who maintain
those drivers mostly, AFAICS.

Best,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/