Re: Should I use kmap or kmap_atomic to map user pages that will bewritten in a loop ?

From: Jonathan Corbet
Date: Sun Jul 26 2009 - 17:27:57 EST


On Sat, 25 Jul 2009 23:41:47 +0200
Laurent Pinchart <laurent.pinchart@xxxxxxxxx> wrote:

> Pages will be written to from the kernel in USB interrupt context. I can then
> either kmap_atomic() pages before copying data and kunmap_atomic() them right
> after, or kmap() them once at the beginning of the video stream and keep them
> mapped until the end.

Video buffers can be big, and the streaming interface requires at least
two of them. That's a lot of kmap'd pages. It seems to me that
kmap_atomic() is the way to go for something like this.

But, then, these are user-space buffers, and you're seemingly buffering
the data through kernel space buffers first? It seems like using
copy_to_user() in a workqueue (or a threaded interrupt handler) might be
a more straightforward way to go, unless I'm missing something.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/