Re: [PATCH] Removed useless retval variables in usb-serial.c

[Greg KH]

On Fri, Jul 24, 2009 at 12:48:03PM -0300, Trevor Pace wrote:
> Removed useless return value variables.

Why are they "useless"?

They seem useful to me, especially as it causes the code to fall out of
the function at the bottom, and not in the middle, which makes
maintaining the code easier to do over time, right?

And did this actually cause any generated code to be
faster/smaller/better?

Oh, and you seem to have messed up a bit of whitespace, please always
run your patches through scripts/checkpatch.pl first.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/