Re: [PATCH 08/19] ceph: address space operations

[Andi Kleen]

> The part I don't understand is what actually happens to pages after the 
> error flag set.  They're still uptodate, but no longer dirty?  And can be 
> overwritten/redirtied?  There's also an error flag on the address_space.  
> Are there any guidelines as far as which should be used?

Ideally both. The Page error flag prevents the data from being
consumed and the address space error flag makes sure errors are 
getting reported on fsync()/close() etc.  Also AS error is useful when
you don't have a clear page to assign the error to, e.g. if you
get an error indication that's not tied to a read operation.

BTW the upcoming hwpoison code can set such errors asynchronously
under you.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/