Re: [PATCH] acerhdf: convert to dev_pm_ops

From: Borislav Petkov
Date: Thu Jul 23 2009 - 05:21:22 EST


On Thu, Jul 23, 2009 at 10:52 AM, Peter Feuerer<peter@xxxxxxxx> wrote:
> Hi Dmitry,
>
> Dmitry Torokhov writes:
>
>> On Wed, Jul 15, 2009 at 08:36:43PM +0200, Peter Feuerer wrote:
>>>
>>> Works fine here, thanks!
>>>
>>> Acked-by: Peter Feuerer <peter@xxxxxxxx>
>>
>> Umm, did you test suspend-to-disk? As far as I understand the new
>> suspend() and resume() methods are onluy used for S2R and for S2D you need
>> to use freeze() and thaw().
>
> No, I didn't test S2D, will have a look at this issue. Thanks for pointing
> out!

Dmitry's right, suspend() and resume() are used only for S2R. Since
the only thing we do when suspending/hibernating is set fan speed to
auto, we might just as well replicate those functions to .freeze() and
.thaw().

/me testing...

--
Regards/Gruss,
Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/