Re: [alsa-devel] [RFC] [PATCH 3/3] ASoC: add support for AmstradE3 (Delta) machine

From: Mark Brown
Date: Thu Jul 23 2009 - 04:57:48 EST


On Wed, Jul 22, 2009 at 09:18:05PM +0200, Janusz Krzysztofik wrote:

> After all, I am not sure what your preferences finally are. If you still think
> that exporting gpio based jack state from ASoC framework over gpiolib sysfs
> doesn't hurt and can be usefull, I'll remove the code from my driver and
> provide a patch against sound/soc/soc-jack.c. But if you would rather prefere
> exposing jack state in a more general, not gpio limited way instead, or
> depend on input layer provided EVIOCGSW ioctl, as Dmitry suggested
> (unfortunatelly, unlike generic ldattach, there is no utility ready for
> use!), I'd rather keep this gpio_export() in my driver, let's say for
> diagnostic purposes, at least until that different option is ready for use in
> a convenient way.

Jack state is already exposed via the input layer by the ALSA jack core.
Reporting of GPIO state via gpio_export() would be additional to that
and would be purely for debug purposes, it would not be recommended for
use by userspace applications.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/