Re: mmotm 2009-07-16-14-32 - lockdep whinge in ext3/quota code

From: Valdis . Kletnieks
Date: Wed Jul 22 2009 - 14:26:28 EST


On Wed, 22 Jul 2009 18:19:23 +0200, Jan Kara said:

> From df60fe9a9d554070e6135087e154bd5aad2cc1b5 Mon Sep 17 00:00:00 2001
> From: Jan Kara <jack@xxxxxxx>
> Date: Wed, 22 Jul 2009 18:12:17 +0200
> Subject: [PATCH] quota: Silence lockdep on quota_on
>
> Commit d01730d74d2b0155da50d44555001706294014f7 didn't completely fix
> the problem since we still take dqio_mutex and i_mutex in the wrong
> order. Move taking of i_mutex further down (luckily it's needed only
> for updating inode flags) below where dqio_mutex is taken.
>
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Applied that fix to the -mmotm I was testing, and the kernel booted quietly.
Feel free to attach a:

Tested-by: Valdis Kletnieks <valdis.kletnieks@xxxxxx>

as it goes upstream. Thanks for the fast patch.

Attachment: pgp00000.pgp
Description: PGP signature