Re: [RFC] move __devinit or __init printk constant format stringsto __devinitconst or __initdata?

[Matt Mackall]

On Tue, 2009-07-21 at 14:20 -0700, Joe Perches wrote:
> Is moving constant string formats to __devinitconst or __initdata
> useful for embedded environments?
> 
> As in:
> 
> #define printk_section(section, fmt, ...)				\
> ({ static const section char __fmt[] = fmt; printk(__fmt, ##__VA_ARGS__); })
> 
> #define pr_err_section(section, fmt, ...) \
> 	printk_section(section, KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> 
> with a use of:
> 
> static int __devinit foo_probe(struct platform_device *pdev)
> {
> 	if (bar())
> 		pr_err_section(__devinitconst,
> 			       "A long error message\n");
> }
> 
> or
> 
> static int __init foo_init(struct platform_device *pdev)
> {
> 	if (bar())
> 		pr_err_section(__initdata,
> 			       "A long error message\n");
> }

Interesting notion, but not worth the trouble in my mind. I think it's
more worthwhile to look into automatic such stuff in the build somehow.

-- 
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/