Re: [KVM PATCH] KVM: introduce "xinterface" API for externalinteraction with guests

[Sam Ravnborg]

> diff --git a/arch/x86/Kbuild b/arch/x86/Kbuild
> index ad8ec35..9f50cc3 100644
> --- a/arch/x86/Kbuild
> +++ b/arch/x86/Kbuild
> @@ -1,5 +1,7 @@
>  
> -obj-$(CONFIG_KVM) += kvm/
> +ifdef CONFIG_KVM
> +obj-y += kvm/
> +endif

What was wrong with the old version?
If this is because xinterface.o is builtin to the kernel then we should
always visit kvm/ and use:

   obj-y += kvm/

unconditionally.



>  
>  # Xen paravirtualization support
>  obj-$(CONFIG_XEN) += xen/
> diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
> index afaaa76..80d951d 100644
> --- a/arch/x86/kvm/Makefile
> +++ b/arch/x86/kvm/Makefile
> @@ -17,3 +17,7 @@ kvm-amd-y		+= svm.o
>  obj-$(CONFIG_KVM)	+= kvm.o
>  obj-$(CONFIG_KVM_INTEL)	+= kvm-intel.o
>  obj-$(CONFIG_KVM_AMD)	+= kvm-amd.o
> +
> +ifdef CONFIG_KVM
> +obj-y += $(addprefix ../../../virt/kvm/, xinterface.o)
> +endif
And when we always visit kvm/ the above code snippet makes sense.
Before we never visited kvm/ unless CONFIG_KVM was defined.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/