Re: [PATCH] mm: count only reclaimable lru pages

From: Rik van Riel
Date: Thu Jul 16 2009 - 10:43:58 EST


Christoph Lameter wrote:
On Thu, 16 Jul 2009, Peter Zijlstra wrote:

What would you suggest? In fact I'm not totally comfortable with it.
Maybe it would be safer to simply stick with the old _lru_pages
naming?
Nah, I like the reclaimable name, these pages are at least potentially
reclaimable.

lru_pages() is definately not correct anymore since you exclude the
unevictable and possibly the anon pages.

Well lets at least add a comment at the beginning of the functions
explaining that these are potentially reclaimable and list some of the
types of pages that may not be reclaimable.

The pages that are not reclaimable will be on the
unevictable LRU list, not on the lists we count.

The only case of pages not being evictable is the
anon pages, once swap fills up.

--
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/