Re: [PATCH 1/3] drivers/hid: Drop NULL test on list_entry result

From: Jiri Kosina
Date: Tue Jul 14 2009 - 11:18:31 EST


On Sun, 12 Jul 2009, Julia Lawall wrote:

> diff --git a/drivers/hid/hid-lgff.c b/drivers/hid/hid-lgff.c
> index 95835ea..987abeb 100644
> --- a/drivers/hid/hid-lgff.c
> +++ b/drivers/hid/hid-lgff.c
> @@ -151,11 +151,6 @@ int lgff_init(struct hid_device* hid)
>
> /* Check that the report looks ok */
> report = list_entry(report_list->next, struct hid_report, list);
> - if (!report) {
> - err_hid("NULL output report");
> - return -1;
> - }
> -
> field = report->field[0];
> if (!field) {
> err_hid("NULL field");
>

Applied, thanks Julia.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/