Re: [PATCH] wireless: wl12xx, fix lock imbalance

[Johannes Berg]

On Mon, 2009-07-13 at 23:51 +0200, Jiri Slaby wrote:
> On 07/13/2009 11:49 PM, Johannes Berg wrote:
> > On Mon, 2009-07-13 at 23:44 +0200, Jiri Slaby wrote:
> > 
> >>> I've had local hacks
> >>> many times to make sparse aware of mutexes, is there a reason they are
> >>> not annotated with __acquire(s)/__release(s) like spinlocks etc.?
> >>
> >> Mutexes are often locked/unlocked interprocedural which I think sparse
> >> can't do much about.
> > 
> > Well, you annotate those functions too, of course.
> 
> Sorry, I don't understand. What functions I annotate?

Well those that take the mutex, e.g.

void acquire_foo(struct foo *f)
{
	mutex_lock(&f->mtx);
}


turns to

void acquire_foo(struct foo *f)
	__acquires(f->mtx)
{
	mutex_lock(&f->mtx);
}

johannes

Attachment: signature.asc
Description: This is a digitally signed message part