Re: iwl: potential deadlock?

From: reinette chatre
Date: Mon Jul 13 2009 - 16:18:48 EST


Hi Jiri,

On Mon, 2009-07-13 at 12:34 -0700, Jiri Slaby wrote:
> Hi,
>
> we found a potential deadlock in iwl code by our tool.

What tool is this?

>
> Can this happen:

I don't think so ...

> iwl_update_tkip_key()
> -> spin_lock_irqsave(&priv->sta_lock)
> -> iwl_send_add_sta()

iwl_send_add_sta() is called here with flags = CMD_ASYNC

In iwl_send_add_sta() we have:
if (ret || (flags & CMD_ASYNC))
return ret;

> -> iwl_sta_ucode_activate()

... so this is not run in this case.

> -> spin_lock_irqsave(&priv->sta_lock)

Reinette

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/