Re: [PATCH 1/3] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids

From: Benjamin Blum
Date: Mon Jul 13 2009 - 11:25:36 EST


On Sun, Jul 12, 2009 at 11:46 PM, Li Zefan<lizf@xxxxxxxxxxxxxx> wrote:
> I think a better demonstration is:
>
>  $ cat tasks
>  1000
>  1001
>  1002
>
>  $ cat procs
>  1000

Indeed.

>> +     /*
>> +      * if the length difference is large enough, we want to allocate a
>> +      * smaller buffer to save memory. if this fails due to out of memory,
>> +      * we'll just stay with what we've got.
>> +      */
>> +     if (PIDLIST_REALLOC_DIFFERENCE(length, dest)) {
>> +             newlist = kmalloc(dest * sizeof(pid_t), GFP_KERNEL);
>
> krealloc()
>

Ah yes. I had thought about krealloc and determined that it wasn't
clever enough to do in-place resizing, but forgot that it could be
used anyway here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/