Re: [PATCH 04/10] percpu: make 4k first chunk allocator map memory

[David Howells]

Tejun Heo <tj@xxxxxxxxxx> wrote:

> +	pr_info("PERCPU: %d 4k pages per cpu, static data %zu bytes\n",
> +		pcpu4k_unit_pages, static_size);

It occurs to me that this is may include a bad assumption.  Page size need not
be 4K.  I don't know that it matters, but looking at this:

> +	vm.size = num_possible_cpus() * pcpu4k_unit_pages << PAGE_SHIFT;
> +	vm_area_register_early(&vm, PAGE_SIZE);

It might.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/