Re: [KVM PATCH v10 2/2] KVM: add ioeventfd support

[Avi Kivity]

On 07/09/2009 06:00 PM, Gregory Haskins wrote:
> > +		bool wildcard = args->flags&  KVM_IOEVENTFD_FLAG_DATAMATCH ?
> > +			true : false;
> >
> >      
> Doh!  Inverted logic.  "wildcard" should be "false" if DATAMATCH is
> defined in the flags.
>
> Avi, please reverse true/false here before accepting (assuming a v11
> respin isn't needed).  Of course, if you would prefer me to just submit
> a new patch, that is fine too.
>
>    

I changed it to !(...).  I find the predicate ? true : false idiom 
confusing.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/