Re: possible regression with pty.c commit

[Sergey Senozhatsky]

On (07/11/09 23:24), Alan Cox wrote:
> On Sat, 11 Jul 2009 22:15:56 +0300
> Sergey Senozhatsky <sergey.senozhatsky@xxxxxxx> wrote:
> 
> > Hello,
> > commit d945cb9cce20ac7143c2de8d88b187f62db99bdc ("pty: Rework the pty layer to use the normal buffering logic")
> > seems to brake kdesu.
> 
> This looks like a timing bug in kdesu at first glance but it may be more
> complex.
> 
> > close(11)                               = 0
> 
> We close one side of the pty/tty pair
> 
> > write(10, "stop", 4)                    = 4
> > write(10, "\n", 1)                      = 1
> > fcntl64(10, F_GETFL)                    = 0x2 (flags O_RDWR)
> > read(10, 0xbf840858, 255)               = -1 EIO (Input/output error)		<<<<<<<<<
> 
> At this point the other side is closed, we have a hangup and the read
> correctly I think gets -EIO.
> 
> I will have a look at kdesu on Monday, I've got Fedora setups here so
> hopefully I can reproduce it simply.
> 

Alan, I forgot to tell - I'm using KDE 3.5.9 (3.5.10). Don't know whether this can be reproduced with KDE 4.x.x.

	Sergey

Attachment: signature.asc
Description: Digital signature