Re: -tip: block, mm: Fix build error in mm/memcontrol.c

[Ingo Molnar]

* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Sat, 11 Jul 2009, Ingo Molnar wrote:
> > 
> > Today's upstream tree build (x86, 64-bit, allyesconfig) failed 
> > with this build error:
> 
> I merged a better fix from Trond, which should make all of this 
> unnecessary (just move BLK_RW_[A]SYNC to the header file that 
> people need anyway).

ok, that's better. I think if in addition to that we also did what i 
suggested:

> Fix it the simplest way for now, by moving the definitions early 
> in blkdev.h (this cannot break anything), but the real fix would 
> be to split up blkdev.h into blkdev-types.h and blkdev-api.h and 
> make only the API definitions/declarations dependent on 
> CONFIG_BLOCK.

would be one step cleaner.

We could then include blkdev-types.h in backing-dev.h so that it 
picks up the constants. Right now having BLK_RW_[A]SYNC in 
backing-dev.h looks a bit weird. No strong opinion though.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/