Re: commit 097041e576ee3a50d92dd643ee8ca65bf6a62e21 (fuse: Fix builderror)

From: Larry Finger
Date: Sat Jul 11 2009 - 13:40:38 EST


Trond Myklebust wrote:
> Hi Linus
>
> Please revert this commit. Instead of fixing the compile problem, it
> adds a new dependency on CONFIG_BLOCK to both NFS and FUSE. Neither one
> of them has such a dependency today, nor is there a reason to introduce
> one.
>
> The correct fix should rather be to move the definitions of BLK_RW_SYNC
> and BLK_RW_ASYNC into backing-dev.h as per the patch below.
>
> Cheers
> Trond

I understand that my "fix" was wrong. I'm sure that Linus is on top of
this, but your patch must be added before reverting 097071e5,
otherwise a new build failure is introduced that might be encountered
when bisecting. Why not undo my changes and add yours in a single patch?

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/