Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test

[Jiri Slaby]

On 07/11/2009 12:17 PM, Jaswinder Singh Rajput wrote:
> On Sat, 2009-07-11 at 10:17 +0200, Jiri Slaby wrote:
>> On 07/11/2009 09:51 AM, Julia Lawall wrote:
>>> --- a/drivers/staging/otus/wwrap.c
>>> +++ b/drivers/staging/otus/wwrap.c
>>> @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
>>>  {
>>>      struct usbdrv_private *macp =
>>>                 container_of(work, struct usbdrv_private, kevent);
>>> -    zdev_t *dev = macp->device;
>>> +    zdev_t *dev;
>>>  
>>>      if (macp == NULL)
>>>      {
>>>          return;
>>>      }
>>
>> The test is rather useless here.
>>
> 
> Why useless, it should be non-null before setting to dev.

Even if work was NULL, macp won't be NULL.

> But issue is why function name like kevent() is global and who is using
> it.

Since it's not declared, I guess nobody but keventd. It should be static.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/