Re: [PATCH 2.6.31] rfkill: allow toggling soft state in sysfs again

[Johannes Berg]

On Fri, 2009-07-10 at 22:09 +0100, Darren Salt wrote:
> I demand that Johannes Berg may or may not have written...
> 
> > Apparently there actually _are_ tools that try to set this in sysfs even
> > though it wasn't supposed to be used this way without claiming first.
> 
> Then it should have been documented as such. I don't see anything about this
> in Documentation/rfkill.txt (as found in 2.6.30), other than a vague
> statement that "Kernel handles events", which isn't exactly helpful :-\

Oh, it's not just that rfkill was horrible, the documentation matched :)
All the SHOUTING in it about what you must and must not do but nothing
actually helpful :)

> > *shrug*, I don't like it, but whatever...
> 
> I do. It means that we have a nice simple text-based interface for use in
> scripts (for now), and a binary interface which is better suited to the likes
> of desktop applications.

Indeed, and as long as you expect to only use soft toggle... problem is
that you won't know whether it's soft-toggled or not while it's
hard-blocked (off)!

> > Please test & report.
> 
> With the patch applied, Bluetooth toggling is working again, so you get to
> add this:
> 
> Tested-By: Darren Salt <linux@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Ok, John, please pick up the patch.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part