Re: [PATCH 2/2] tracing/kmemtrace: Use the %pf format

From: Li Zefan
Date: Fri Jul 10 2009 - 01:17:51 EST


Frederic Weisbecker wrote:
> Remove the obsolete seq_print_ip_sym() usage and replace it
> by the %pf format in order to print function symbols.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

Reviewed-by: Li Zefan <lizf@xxxxxxxxxxxxxx>

...

> - /* Skip node */
> - ret = trace_seq_printf(s, " ");
> + /* Skip node and print call site*/

a nitpick:

missing a space before '*/'

> + ret = trace_seq_printf(s, " %pf\n", (void *)entry->call_site);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/