Re: [PATCH] rework/fix is_single_threaded()

[David Howells]

Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> Unless David replies.

Sorry, I missed the last three messages.

> David, do you still dislike ->mmap_sem? I didn't see other objections,
> and again, imho tasklist_lock is worse.

My main objection to taking mmap_sem is that it restricts where the function
can be used.  It can't, for example, be called by anyone holding a spinlock.
Furthermore, the more locks, the more chance of someone accidentally
deadlocking something.

But apart from that, go for it.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/